Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Also update companions of companions before merge #352

Closed
joao-paulo-parity opened this issue Jan 5, 2022 · 1 comment · Fixed by #354
Closed

Also update companions of companions before merge #352

joao-paulo-parity opened this issue Jan 5, 2022 · 1 comment · Fixed by #354
Assignees

Comments

@joao-paulo-parity
Copy link
Contributor

joao-paulo-parity commented Jan 5, 2022

This is yet another "companion build system design problem" to add onto #327.

Showcased by the interaction between paritytech/substrate#10463, paritytech/polkadot#4519 and paritytech/cumulus#870.

Similar to what was done for paritytech/pipeline-scripts#23, in case a Substrate PR has companions on Polkadot and Cumulus, it's not enough to update only Substrate for Cumulus: the Polkadot PR should be updated into the Cumulus PR as well.

Instead of the current:

  1. Merge Substrate PR
  2. Update lockfile of Polkadot and Cumulus
  3. Wait to merge

It should be

  1. Merge Substrate PR
  2. Update the lockfile of the Polkadot PR
  3. Wait for Polkadot PR to be merged
  4. Update the lockfile of Cumulus with both Substrate and Polkadot
  5. Merge Cumulus PR
@joao-paulo-parity
Copy link
Contributor Author

This needs #359 before it is released

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant