Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ethcore: add missing builtins benchmarks #9170

Merged
merged 2 commits into from
Jul 20, 2018
Merged

ethcore: add missing builtins benchmarks #9170

merged 2 commits into from
Jul 20, 2018

Conversation

andresilva
Copy link
Contributor

@andresilva andresilva commented Jul 19, 2018 •
edited
Loading

Fixes #9152.

Adding fe3cfa8 and 7970ef1. Everything else was already in master.

@andresilva andresilva added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 19, 2018
@andresilva andresilva requested a review from debris July 19, 2018 14:44
@andresilva andresilva changed the title ethcore: add modexp benchmarks ethcore: add missing builtins benchmarks Jul 19, 2018
@andresilva andresilva mentioned this pull request Jul 19, 2018
Closed
sorpaas
sorpaas approved these changes Jul 20, 2018
View reviewed changes
Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just not sure whether ethcore::builtin::ethereum_builtin is meant to be public, but I think it does no harm either way.

niklasad1
niklasad1 approved these changes Jul 20, 2018
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 20, 2018
@debris debris merged commit fb2b77e into master Jul 20, 2018
@debris debris deleted the andre/add-modexp-benchmarks branch July 20, 2018 13:06
@5chdn 5chdn added this to the 2.1 milestone Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@debris debris debris approved these changes

@sorpaas sorpaas sorpaas approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
5 participants
@andresilva @debris @sorpaas @niklasad1 @5chdn