Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix some warns on nightly #8889

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Fix some warns on nightly #8889

merged 1 commit into from
Jun 14, 2018

Conversation

niklasad1
Copy link
Collaborator

warning: a method with this name may be added to the standard library in the future
   --> ethcore/src/engines/authority_round/mod.rs:718:56
    |
718 |         let remaining = self.step.inner.duration_remaining().as_millis();
    |                                                              ^^^^^^^^^
    |
    = note: #[warn(unstable_name_collisions)] on by default
    = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
    = help: call with fully qualified syntax `engines::authority_round::AsMillis::as_millis(...)` to keep using the current method
    = note: add #![feature(duration_as_u128)] to the crate attributes to enable `std::time::Duration::as_millis`

warning: a method with this name may be added to the standard library in the future
   --> ethcore/src/engines/authority_round/mod.rs:728:47
    |
728 |             while self.step.inner.duration_remaining().as_millis() == 0 {
    |                                                        ^^^^^^^^^
    |
    = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
    = help: call with fully qualified syntax `engines::authority_round::AsMillis::as_millis(...)` to keep using the current method
    = note: add #![feature(duration_as_u128)] to the crate attributes to enable `std::time::Duration::as_millis`

warning: a method with this name may be added to the standard library in the future
   --> ethcore/src/engines/authority_round/mod.rs:738:59
    |
738 |             let next_run_at = self.step.inner.duration_remaining().as_millis() >> 2;
    |                                                                    ^^^^^^^^^
    |
    = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
    = help: call with fully qualified syntax `engines::authority_round::AsMillis::as_millis(...)` to keep using the current method
    = note: add #![feature(duration_as_u128)] to the crate attributes to enable `std::time::Duration::as_millis`

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Jun 13, 2018
@5chdn 5chdn added this to the 1.12 milestone Jun 13, 2018
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 14, 2018
@debris debris merged commit 9e87278 into master Jun 14, 2018
@debris debris deleted the nightly-fix-some-warns branch June 14, 2018 08:58
dvdplm added a commit that referenced this pull request Jun 16, 2018
* master:
  Minor fix in chain supplier and light provider (#8906)
  Block 0 is valid in queries (#8891)
  fixed osx permissions (#8901)
  Atomic create new files with permissions to owner in ethstore (#8896)
  Add ETC Cooperative-run load balanced parity node (#8892)
  Add support for --chain tobalaba (#8870)
  fix some warns on nightly (#8889)
  Add new ovh bootnodes and fix port for foundation bootnode 3.2 (#8886)
  SecretStore: service pack 1 (#8435)
tavakyan referenced this pull request in C4Coin/c4coin-parity Jun 18, 2018
ordian added a commit to ordian/parity that referenced this pull request Jun 20, 2018
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity: (29 commits)
  Block 0 is valid in queries (openethereum#8891)
  fixed osx permissions (openethereum#8901)
  Atomic create new files with permissions to owner in ethstore (openethereum#8896)
  Add ETC Cooperative-run load balanced parity node (openethereum#8892)
  Add support for --chain tobalaba (openethereum#8870)
  fix some warns on nightly (openethereum#8889)
  Add new ovh bootnodes and fix port for foundation bootnode 3.2 (openethereum#8886)
  SecretStore: service pack 1 (openethereum#8435)
  Handle removed logs in filter changes and add geth compatibility field (openethereum#8796)
  fixed ipc leak, closes openethereum#8774 (openethereum#8876)
  scripts: remove md5 checksums (openethereum#8884)
  hardware_wallet/Ledger `Sign messages` + some refactoring (openethereum#8868)
  Check whether we need resealing in miner and unwrap has_account in account_provider (openethereum#8853)
  docker: Fix alpine build (openethereum#8878)
  Remove mac os installers etc (openethereum#8875)
  README.md: update the list of dependencies (openethereum#8864)
  Fix concurrent access to signer queue (openethereum#8854)
  Tx permission contract improvement (openethereum#8400)
  Limit the number of transactions in pending set (openethereum#8777)
  Use sealing.enabled to emit eth_mining information (openethereum#8844)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants