This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Allow CORS requests in Secret Store API #10584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @adetante signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
sorpaas
approved these changes
Apr 11, 2019
sorpaas
added
A8-looksgood 🦄
svyatonik
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
Thanks for contribution! Have you considered using cors module from jsonrpc-server-utils crate? Looks like there are some caveats (like case-insensitive origin matching) that are covered there.
|
You're right: I'm going to change my implementation to the jsonrpc-server-utils crate. |
svyatonik
added
A3-inprogress ⏳
|
I updated based on your comments. |
|
Test failure seems unrelated - SS tests are working fine on my laptop. |
svyatonik
added
A8-looksgood 🦄
sorpaas
approved these changes
Apr 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the same model as what is done for JSON-RPC, this PR allows to specify the list of domains to allow for cross-domain requests to Secret Store API.
With CLI flag
--secretstore-http-cors=http://mydomainor in the toml configuration file.The default behavior is the same as the current one: all cross-domain requests are rejected.