Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftover relays/headers folder #1212

Closed
acatangiu opened this issue Nov 15, 2021 · 0 comments · Fixed by #1216
Closed

Remove leftover relays/headers folder #1212

acatangiu opened this issue Nov 15, 2021 · 0 comments · Fixed by #1216
Assignees
@acatangiu
Labels
Good First Issue Good for newcomers Help Wanted An external contribution is desired. P-Relay

Comments

@acatangiu
Copy link
Collaborator

Since #1210, the only thing used anymore in the relays/headers folder is SyncLoopMetrics.

We may move SyncLoopMetrics to the finality relay and only keep best_block_numbers (as the blocks_in_state is not relevant anymore).
@svyatonik svyatonik added Good First Issue Good for newcomers Help Wanted An external contribution is desired. P-Relay labels Nov 15, 2021
@acatangiu acatangiu self-assigned this Nov 16, 2021
@acatangiu acatangiu mentioned this issue Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acatangiu acatangiu

Labels
Good First Issue Good for newcomers Help Wanted An external contribution is desired. P-Relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused relays/headers acatangiu/parity-bridges-common
2 participants
@svyatonik @acatangiu