Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP/WebSocket: Fix memory leak of pending dials #269

Closed
lexnv opened this issue Oct 22, 2024 · 0 comments · Fixed by #271
Closed

TCP/WebSocket: Fix memory leak of pending dials #269

lexnv opened this issue Oct 22, 2024 · 0 comments · Fixed by #271
Labels
bug Something isn't working

Comments

@lexnv
Copy link
Collaborator

lexnv commented Oct 22, 2024

The state tracking of pending dials from TCP / WebSocket is monotonically increasing over time.

This leads to leaking memory. We need to ensure that any pending_dials are removed from the internal state as soon as the dial is successful / unsuccessful.

TCP pending dials

Screenshot 2024-10-22 at 12 40 57

WebSocket pending dials

Screenshot 2024-10-22 at 14 01 57

cc @paritytech/networking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

transport: Fix pending dials memory leak paritytech/litep2p
1 participant
@lexnv