[dependencies]: upgrade tokio to v0.3 #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a rough ETA for hyper running on new tokio? |
There's a ticket up. First step is to port So I suspect it might be a while. |
maciejhirsz
approved these changes
Oct 16, 2020
|
It seems like hyper v0.14 is quite close to a release, so let's wait for it. |
|
Let's migrate directly to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR upgrades tokio to
v0.3buthyper v0.13still requirestokio v0.2so it requires a compat layer which causes us to have both tokiov0.2 and v0.3in the dependency graph.Nothing urgent, we can wait on hyper to update or just accept a bigger dependency tree for now.