Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to discern address in use error #562

Closed
Tracked by #492
maciejhirsz opened this issue Nov 15, 2021 · 3 comments
Closed
Tracked by #492

Unable to discern address in use error #562

maciejhirsz opened this issue Nov 15, 2021 · 3 comments

Comments

@maciejhirsz
Copy link
Contributor

When the JSON-RPC address is in use, Substrate retries with a random port. This work fine with jsonrpc, but we unfortunately erase std::io errors type with anyhow.

We should have a new error variant(s) just for AddressInUse | PermissionDenied. Bonus points if we can either not consume the builder, or return the builder in the error for easy retries. Alternatively support the strategy of trying random port directly into jsonrpsee.

@maciejhirsz maciejhirsz mentioned this issue Nov 15, 2021
10 tasks
@niklasad1
Copy link
Member

right, didn't think about this....

@dvdplm
Copy link
Contributor

dvdplm commented Nov 15, 2021

Alternatively support the strategy of trying random port directly into jsonrpsee.

I think this is highly application specific and that we should not do it in jsonrpsee.

@maciejhirsz
Copy link
Contributor Author

Solved by #567.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants