Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server]: unsubscribe_call doesn't close subscriptions as intended #135

Closed
niklasad1 opened this issue Oct 21, 2020 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@niklasad1
Copy link
Member

niklasad1 commented Oct 21, 2020

When an unsubscription call is received by the Server then RawServerSubscriptionId::from_wire_message tries to parse it from hardcoded JsonValue::Null where the subscription ID should be parsed instead. Thus, RawServerSubscriptionId::from_wire_message always fails to parse the subscription ID

This causes dropping a registered subscription not work with one exception when the entire client is dropped then it works via SubscriptionsClosed

@niklasad1 niklasad1 added the bug Something isn't working label Oct 21, 2020
@niklasad1 niklasad1 changed the title [server raw]: unsubscribe doesn't work [server]: unsubscribe doesn't close subscriptions as intended. Oct 21, 2020
@dvdplm
Copy link
Contributor

dvdplm commented Oct 21, 2020

Maybe unrelated but I think null is a valid JSON document.

@niklasad1
Copy link
Member Author

niklasad1 commented Oct 21, 2020

Yeah, it is unrelated the problem is that JsonValue::Null is hardcoded instead the subscription ID should be parsed from the request/method call. I rephrased the description hopefully more understandable now

@niklasad1 niklasad1 changed the title [server]: unsubscribe doesn't close subscriptions as intended. [server]: unsubscribe_call doesn't close subscriptions as intended Oct 21, 2020
@niklasad1
Copy link
Member Author

Fixed by #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants