delegate_dependency api calls
#2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
changed the title
delegate_dependency env api callsdelegate_dependency api calls
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
+ Coverage 53.64% 53.67% +0.02%
==========================================
Files 224 224
Lines 7046 7046
Branches 3118 3118
==========================================
+ Hits 3780 3782 +2
+ Misses 3266 3264 -2 ☔ View full report in Codecov by Sentry. |
SkymanOne
reviewed
Feb 19, 2024
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Fri Feb 23 19:33:22 CET 2024 |
SkymanOne
reviewed
Feb 19, 2024
SkymanOne
reviewed
Feb 19, 2024
integration-tests/upgradeable-contracts/delegator/delegatee2/Cargo.toml
Outdated
Show resolved
Hide resolved
SkymanOne
reviewed
Feb 19, 2024
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 20, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 20, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
paritytech-ci
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 20, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
…argo.toml Co-authored-by: Gherman <[email protected]>
Co-authored-by: Gherman <[email protected]>
franciscoaguirre
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 22, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
cmichi
reviewed
Feb 23, 2024
cmichi
reviewed
Feb 23, 2024
| @@ -0,0 +1,20 @@ | |||
| [package] | |||
| name = "delegatee2" | |||
There was a problem hiding this comment.
Can you add a mention of the lock/unlock mechanism and the delegate2 package to https://github.com/paritytech/ink/tree/430a831b1e4084e154744910f36a9f40516699fe/integration-tests/upgradeable-contracts#delegator?
There was a problem hiding this comment.
Ah oops I did that in the wrong PR 🙈 it is here: https://github.com/paritytech/ink/pull/2123/files#diff-7cf9db86b007053cf1ad83c5196420d3e5c582a7b3dbbc5d73edca22b4a452fa
Co-authored-by: Michael Müller <[email protected]>
Co-authored-by: Michael Müller <[email protected]>
Co-authored-by: Michael Müller <[email protected]>
Co-authored-by: Michael Müller <[email protected]>
Merged
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for two new host functions
lock_delegate_dependency: prevents the code at the given code hash for being removed.unlock_delegate_dependency: releases the lock on the code being removed from the current contract.Having a delegate dependency allows contracts to safely delegate to another
code_hashwith the guarantee that it cannot be deleted. See paritytech/substrate#14079.I have modified the
upgradeable-contracts/delegatorintegration test to demonstrate these new calls. For that purpose I have also addedremove_codeextrinsic to the e2e client.🟡 Requires version of
pallet_contractsincluding paritytech/polkadot-sdk@d250a6e