Persist Environment in metadata
#1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
==========================================
- Coverage 70.76% 70.67% -0.10%
==========================================
Files 206 206
Lines 6455 6581 +126
==========================================
+ Hits 4568 4651 +83
- Misses 1887 1930 +43
... and 56 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SkymanOne
commented
Apr 7, 2023
| @@ -16,7 +16,6 @@ categories = ["no-std", "embedded"] | |||
| include = ["Cargo.toml", "src/**/*.rs", "README.md", "LICENSE"] | |||
|
|
|||
| [dependencies] | |||
| ink_metadata = { version = "4.1.0", path = "../metadata", default-features = false, features = ["derive"], optional = true } | |||
There was a problem hiding this comment.
Removed this because it seems it is not used anywhere.
cmichi
reviewed
Apr 12, 2023
cmichi
reviewed
Apr 12, 2023
cmichi
approved these changes
Apr 12, 2023
added 2 commits
April 12, 2023 21:07
Merged
This was referenced Apr 25, 2023
goastler
added a commit
to prosopo/ink_sr25519
that referenced
this pull request
Jul 31, 2023
goastler
added a commit
to prosopo/ink_sr25519
that referenced
this pull request
Aug 2, 2023
SkymanOne
pushed a commit
that referenced
this pull request
Aug 9, 2023
* sr25519 signature verification * offchain signature verification * fmt * schnorrkel optional * update dictionary * fix * update changelog * add info about unstable function usage * missing docs * review suggestions * added catch for invalid public key or signature in sr25519 verification public key byte[] and/or signature byte[] may not be constructed into a PublicKey or Signature if it's in the wrong format. These errors originate from the schnorrkel library and need to be caught, otherwise it'll panic and propagate up to smart contracts in ink. * switched to simple signing context in sr25519_verify fn there is no need to make the context directly, we can delegate that to the schnorrkel library * Added docs for sr25519_verify() Docs + example + notes about context set to "substrate" * Added docs to sr25519VerifyFailed error Helpful for debugging why the error has occurred, as there is only ever one of 3 reasons: invalid public key, invalid message or invalid signature * Added docs link to substrate sr25519 signing context * cargo fmt * Remove reference on message variable of sr25519_verify() Not required according to clippy * Clippy embed error in panic statement during metadata execution Clippy's advice * sr25519 verification tests Tested invalid public key, invalid signature, invalid message and valid case * Updated sr25519_verify PR number in CHANGELOG.md * Fix comment to adhere to spell check in sr25519 verification tests * add parity as author of sr25519 module Co-authored-by: Green Baneling <[email protected]> * ignore semicolon correction in item module * add warning to docs for sr25519_verify() depending on unstable interfaces * remove space typo from sr25519 docs * remove #1741 from changelog * added documentation to the dummy method in sr25519_verification example * typo in sr25519 example contract dummy method * spell check fix in method doc for sr25519 * spell check fix in method doc for sr25519 * move changelog entry for #1741 * changelog typo --------- Co-authored-by: kziemianek <[email protected]> Co-authored-by: Green Baneling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1695 by adding a field
environmenttometadata.jsonwhich contains the info about the types of the contract's environment.