Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Add customizable providers for validator-set and payload (for tests) #406

Closed
acatangiu opened this issue Mar 22, 2022 · 1 comment · Fixed by paritytech/substrate#11183
Closed

Add customizable providers for validator-set and payload (for tests) #406

acatangiu opened this issue Mar 22, 2022 · 1 comment · Fixed by paritytech/substrate#11183
Assignees
@acatangiu
Milestone
Some Day Maybe

Comments

@acatangiu
Copy link
Collaborator

Coming from https://github.com/paritytech/substrate/pull/10882/files#r831269655

I'm not really fond of mixing test-specific code with the general implementation. In this case it seems that we should instead allow changing the provider of validators (so we can mock it in tests), and also a provider for the payload (so we can create random mmr roots, potentially corrupted). I'm OK with fixing in a follow-up PR.
@acatangiu acatangiu added this to the Some Day Maybe milestone Mar 22, 2022
@acatangiu acatangiu mentioned this issue Mar 22, 2022
Merged
This was referenced Apr 4, 2022
Closed
Merged
@acatangiu acatangiu self-assigned this Apr 13, 2022
@acatangiu
Copy link
Collaborator Author

fixed in paritytech/substrate#11183

@acatangiu acatangiu added this to BEEFY Jun 28, 2022
@acatangiu acatangiu moved this to Done ✅ in BEEFY Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@acatangiu acatangiu

Labels
None yet
Projects
No open projects
BEEFY
Status: Done ✅
Milestone
Some Day Maybe
Development

Successfully merging a pull request may close this issue.

Expose MMR root through runtime API - use it in BEEFY client acatangiu/substrate
1 participant
@acatangiu