This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion to substrate #10196 - Add group name in task metrics #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
bkchr
approved these changes
Nov 9, 2021
Signed-off-by: Andrei Sandu <[email protected]>
ordian
reviewed
Nov 11, 2021
| sc-cli = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.12" } | ||
| substrate-test-utils = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.12" } | ||
| sc-cli = { git = "https://github.com/paritytech/substrate", branch = "master" } | ||
| substrate-test-utils = { git = "https://github.com/paritytech/substrate", branch = "master" } |
There was a problem hiding this comment.
@bkchr looks like some leftovers? (this is in master)
There was a problem hiding this comment.
Yeah for sure. Interesting that this worked :P
ordian
approved these changes
Nov 11, 2021
|
bot merge |
|
Waiting for commit status. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use blank group name parameter for task spawn() calls. These changes are related to this polkadot issue: paritytech/polkadot#4198
Substrate PR: paritytech/substrate#10196