Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extrinsics: fix Vec<AccountId> args #519

Merged
merged 4 commits into from
Apr 26, 2022
Merged

extrinsics: fix Vec<AccountId> args #519

merged 4 commits into from
Apr 26, 2022

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Apr 22, 2022

Where a message or a constructor accepts a Vec<AccountId> as an argument e.g multisig, the custom decoder should be used so that SS58 format. e.g.

 contract instantiate \
      --args 2 [5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY,5FHneW46xGXgs5mUiveU4sbTyGBzmstUspZC92UhjJM694ty] \
      --suri //Alice \
      --dry-run

@ascjones ascjones marked this pull request as ready for review April 25, 2022 16:03
@cmichi
Copy link
Collaborator

cmichi commented Apr 26, 2022

@ascjones What about (AccountId, …)?

@ascjones
Copy link
Collaborator Author

@ascjones What about (AccountId, …)?

You mean composite types containing an AccountId? Already handled: https://github.com/paritytech/cargo-contract/blob/cfd55bd66811f959e465bd7f1b6d5d60e2240fbc/src/cmd/extrinsics/transcode/transcoder.rs#L583

@ascjones ascjones merged commit 6c0d521 into master Apr 26, 2022
@ascjones ascjones deleted the aj/vec-args branch April 26, 2022 08:26
@ascjones ascjones mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants