Always use lib.name for Wasm output file name
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
May 24, 2021
| original_wasm.set_extension("wasm"); | ||
|
|
||
| // {target_dir}/{package_name}.wasm | ||
| let mut dest_wasm = target_directory.clone(); | ||
| dest_wasm.push(package_name.clone()); | ||
| dest_wasm.push(lib_name.clone()); |
There was a problem hiding this comment.
Note that package_name will still be used for the contract bundle, which could be confusing when viewing the target dir if they are different.
We could just replace the package_name field CrateMetadata with something like contract_artifact_name, and populate with the lib name.
There was a problem hiding this comment.
Good point, I updated the PR.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221.