Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest binaryen installation from GitHub on outdated version #274

Merged
merged 2 commits into from
May 12, 2021
Merged

Suggest binaryen installation from GitHub on outdated version #274

merged 2 commits into from
May 12, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented May 12, 2021

This came up more often recently. Latest in #272, but also in the public channel.

@cmichi cmichi requested a review from ascjones May 12, 2021 08:27
ascjones
ascjones approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there is a test which checks that string failing. Should probably change the test to not match on the string exactly,

@cmichi cmichi merged commit 7a75fe9 into master May 12, 2021
@cmichi cmichi deleted the cmichi-link-binaryen-gh branch May 12, 2021 09:38
@cmichi cmichi mentioned this pull request May 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmichi @ascjones