Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect version mismatches of parity-scale-codec #237

Merged
merged 5 commits into from
Mar 26, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Mar 25, 2021

Closes #232.

CI currently fails because master fails (see #236 for the fix for that).

@Robbepop @ascjones Are you aware of any other dependencies of a contract which must be compatible with the ink! version of that dependency? scale-info?

@cmichi cmichi requested a review from ascjones March 25, 2021 07:33
@ascjones
Copy link
Collaborator

Yes the versions of scale-info should match

src/cmd/build.rs Outdated Show resolved Hide resolved
@cmichi
Copy link
Collaborator Author

cmichi commented Mar 26, 2021

That's the current output:

$ cargo run -- contract build --manifest-path /tmp/foo/Cargo.toml 
error: There are multiple `scale-info` packages in your project, and the specification `scale-info` is ambiguous.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:
  scale-info:0.3.0
  scale-info:0.6.0
ERROR: Mismatching versions of `scale-info` were found!
Please ensure that your contract and your ink! dependencies use a compatible version of this package.

Mismatches of parith-scale-codec and scale-info are detected.

@ascjones
Copy link
Collaborator

Looks good but CI failing with compilation error.

@ascjones
Copy link
Collaborator

CI fix merged to master so just needs merging in here

Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This should save us a lot of time answering this common problem.

@cmichi cmichi merged commit ec6cbce into master Mar 26, 2021
@cmichi cmichi deleted the cmichi-detect-parity-scale-codec-mismatch branch March 26, 2021 11:12
@cmichi cmichi mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect mismatches of parity-scale-codec in contract vs. ink!
2 participants