Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress output on --quiet #165

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Jan 29, 2021

Closes #134.

Supersedes #133.

From the issue:

[…] investigate whether we should print progress updates to stderr as I believe cargo does (needs confirming).

I investigated and the cargo behavior is that progress output is suppressed entirely for --quiet, but errors are still printed to stderr. This is the behavior which I implemented in this PR.

@cmichi cmichi requested a review from ascjones January 29, 2021 06:37
src/cmd/build.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/util.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmichi cmichi merged commit dfcca38 into master Feb 3, 2021
@cmichi cmichi deleted the cmichi-make-quiet-really-silent branch February 3, 2021 10:29
@ascjones ascjones mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiet verbosity effects
2 participants