-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not generate build artifacts under target
for check
#124
Do not generate build artifacts under target
for check
#124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than building into a tmp dir, did you consider running cargo check
instead of cargo build
when invoking cargo for wasm and metadata gen?
e.g. I just ran the raw command cargo check --target wasm32-unknown-unknown -Zbuild-std -Zbuild-std-features=panic_immediate_abort --no-default-features
and it worked as expected.
@ascjones Thanks for the comments, I applied all of them. Can you take another look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Our documentation for
cargo contract check
:I found that despite this comment we actually output to the
target
dir. This PR changes this behavior by makingcheck
build into a tmp dir.