Enable Wasm sign_ext #1189
Merged
Enable Wasm sign_ext #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
requested review from
cmichi,
ascjones,
HCastano and
SkymanOne
as code owners
|
Let's keep the PR open until the support comes so we don't break the master |
|
How would we break master? And which master? The development in this repo is blocked unless you downgrade rustc or merge this PR. It doesn't break anything. It keeps working if you use rustc < 1.70 and it didn't work with rustc >= 1.70 before. It just to unblock development here. |
ascjones
approved these changes
Jul 3, 2023
|
Yeah we probably should have a warning. |
|
Added a warning if a new rustc is used. I didn't want to scan for the instructions to not add additional dependencies on |
This reverts commit aa2a2e6.
|
Reverted my CI change because the integration tests fail with |
Merged
Merged
ascjones
added a commit
that referenced
this pull request
Aug 21, 2023
* Enable Wasm sign_ext * Bump substrate crates * Add warning when building with new rustc * Stable toolchain * Revert "Stable toolchain" This reverts commit aa2a2e6. --------- Co-authored-by: Andrew Jones <[email protected]>
ascjones
added a commit
that referenced
this pull request
Aug 22, 2023
* Add `SignextLowering` pass to `wasm-opt` (#1280) * Add `SignextLowering` pass to `wasm-opt` * Remove check for Rust version (cherry picked from commit 756aa38) * Update wasm-opt * Cargo.lock * Enable Wasm sign_ext (#1189) * Enable Wasm sign_ext * Bump substrate crates * Add warning when building with new rustc * Stable toolchain * Revert "Stable toolchain" This reverts commit aa2a2e6. --------- Co-authored-by: Andrew Jones <[email protected]> * Cargo.lock * Remove version check * WIP updating subxt * Updating subxt --------- Co-authored-by: Alexander Theißen <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1139
Since Rustc 1.70 we can't disable signed extension anymore. Hence we have to allow it in order to keep functioning. Eventually, we want to remove the
parity-wasmdependency but for now we can just enable thesign_extfeature.Please note that those contracts will not deploy on
pallet-contracts, yet. Support is coming soon.