Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit with 1 on Err #109

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Exit with 1 on Err #109

merged 1 commit into from
Nov 16, 2020

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 13, 2020 •
edited
Loading

You can provoke this by e.g. applying this patch to ink/examples/dns/Cargo.toml:

 [lib]
-name = "dns"
+name = "d ns"

and then

cargo run -- contract build --manifest-path ../ink/examples/dns/Cargo.toml 
echo $?

After the merge we should move the ink-ci-v0.8.0 tag ahead to this commit.

This is another reason why some of the stages in the ink! CI succeed even though cargo-contract fails.

@cmichi cmichi requested a review from ascjones November 13, 2020 21:47
ascjones
ascjones approved these changes Nov 16, 2020
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones merged commit 3967026 into master Nov 16, 2020
@ascjones ascjones deleted the cmichi-exit-with-1-on-error branch November 16, 2020 09:39
@ascjones ascjones mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmichi @ascjones