Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swc #6694

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Bump swc #6694

merged 4 commits into from
Aug 23, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Aug 8, 2021

No description provided.

@height
Copy link

height bot commented Aug 8, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Aug 8, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.05s -17.00ms
Cached 299.00ms +13.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 617.00ms -41.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 617.00ms -42.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 617.00ms -42.00ms 🚀
dist/legacy/index.8833cebd.js 1.54kb +0.00b 897.00ms -51.00ms 🚀
dist/legacy/index.9106df33.js 1.15kb +0.00b 897.00ms -51.00ms 🚀
dist/modern/index.c6061158.js 1.08kb +0.00b 896.00ms -52.00ms 🚀
dist/legacy/index.html 775.00b +0.00b 1.03s -70.00ms 🚀
dist/modern/index.html 715.00b +0.00b 1.03s -69.00ms 🚀
dist/legacy/index.5ba75694.css 77.00b +0.00b 1.16s -66.00ms 🚀
dist/modern/index.14235cd8.css 77.00b +0.00b 1.16s -67.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/index.html 775.00b +0.00b 1.01s -72.00ms 🚀
dist/modern/index.html 715.00b +0.00b 1.01s -73.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 9.97s -114.00ms
Cached 457.00ms +9.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/logo.1e014c76.png 274.00b +0.00b 225.00ms -4.74s 🚀

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.15m +126.00ms
Cached 1.67s +10.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.470ba655.js 1.77mb +2.00b ⚠️ 19.50s +47.00ms
dist/pdfRenderer.3aa0cd1a.js 1.11mb +12.00b ⚠️ 52.86s +895.00ms
dist/index.5b3271c4.js 694.59kb -11.00b 🚀 52.83s +14.48s ⚠️
dist/editorView.29fe11b7.js 594.90kb +0.00b 52.78s +14.43s ⚠️
dist/popup.2462355b.js 209.65kb +0.00b 52.78s +14.43s ⚠️
dist/index.7cbeb3e5.js 145.42kb +0.00b 52.83s +14.48s ⚠️
dist/Toolbar.8100e9d3.js 107.22kb +0.00b 52.78s +14.43s ⚠️
dist/card.24b627bf.js 62.65kb +0.00b 52.78s +14.43s ⚠️
dist/Modal.cefac07c.js 45.30kb +15.00b ⚠️ 52.78s +14.43s ⚠️
dist/ui.a9ef7fc0.js 14.93kb +0.00b 52.78s +14.43s ⚠️
dist/smartMediaEditor.1b5005da.js 13.24kb +0.00b 52.78s +14.43s ⚠️
dist/dropzone.0d183115.js 12.13kb +0.00b 52.78s +14.43s ⚠️
dist/card.45f850d6.js 5.75kb +0.00b 52.78s +14.43s ⚠️
dist/EmojiPickerComponent.55e0a64c.js 3.71kb +0.00b 52.78s +14.43s ⚠️
dist/dropzone.a10cce43.js 3.28kb +0.00b 52.78s +14.43s ⚠️
dist/Modal.7f4c60b3.js 3.13kb +0.00b 52.78s +14.43s ⚠️
dist/clipboard.d25985ee.js 2.92kb +0.00b 52.78s +14.43s ⚠️
dist/ResourcedEmojiComponent.78f6ddfc.js 2.10kb +0.00b 52.78s +14.43s ⚠️
dist/browser.09200cd5.js 1.68kb +0.00b 52.78s +14.43s ⚠️
dist/media-card-analytics-error-boundary.75fac461.js 1.10kb +0.00b 52.78s +14.43s ⚠️
dist/media-picker-analytics-error-boundary.cfe02cc6.js 949.00b +0.00b 52.78s +14.43s ⚠️
dist/media-card-analytics-error-boundary.596dbab3.js 945.00b +0.00b 52.78s +14.43s ⚠️
dist/simpleHasher.2a6e12b6.js 626.00b +0.00b 52.78s +14.43s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/pdfRenderer.c42a5d74.js 1.11mb +12.00b ⚠️ 54.07s +1.03s
dist/index.1e37a90b.js 694.59kb -11.00b 🚀 54.04s +1.03s

Three.js ✅

Timings

Description Time Difference
Cold 7.29s -102.00ms
Cached 390.00ms -11.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic marked this pull request as draft August 11, 2021 07:55
@mischnic mischnic marked this pull request as ready for review August 17, 2021 18:46
@@ -126,7 +126,6 @@ impl<'a> Fold for EnvReplacer<'a> {
}
}
PatOrExpr::Expr(expr) => Some(&**expr),
_ => None,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This was a preexisting warning because the PatOrExpr enum only has two members and the switch is therefore already exhaustive)

@devongovett devongovett merged commit 95f5648 into v2 Aug 23, 2021
@devongovett devongovett deleted the bump-swc branch August 23, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants