flow typings for node's built-in Module module
#5364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Will Binns-Smith <[email protected]>
|
gorakong
force-pushed
the
gkong/node-module-flow
branch
from
434491e
to
80c4802
Compare
gorakong
changed the title
Module module
|
Maybe we should also try upstreaming this: https://github.com/facebook/flow/blob/05cd1bae10d89c9d4155ab99d2d1a9ed5eca9f9b/lib/node.js#L125-L130 |
|
@mischnic sounds good! will be following up with a submission to the Node.js libdef in the main flow repo |
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
gorakong
force-pushed
the
gkong/node-module-flow
branch
3 times, most recently
from
184b0b0
to
2b1e3d6
Compare
…rcel into gkong/node-module-flow
gorakong
force-pushed
the
gkong/node-module-flow
branch
from
2b1e3d6
to
f8970de
Compare
wbinnssmith
reviewed
Nov 23, 2020
flow-libs/module.js.flow
Outdated
| declare type FilePath = string; | ||
|
|
||
| // Derived from https://github.com/facebook/flow/blob/61913b9f0dcd564fd4c74fefbe896b33ef447cab/lib/node.js | ||
| declare class Url { |
There was a problem hiding this comment.
import type {URL} from 'url'?
There was a problem hiding this comment.
looks like this is addressed in the upstream PR :) facebook/flow#8540
…rcel into gkong/node-module-flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: