Propagate symbols data in bundler #4375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark Resultspackages/benchmarks/three 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... packages/benchmarks/kitchen-sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... packages/benchmarks/react-hn 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... packages/benchmarks/ak-editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
mischnic
force-pushed
the
bundler-propagate
branch
from
afd9efb
to
fd05b6d
Compare
mischnic
force-pushed
the
bundler-propagate
branch
from
fd05b6d
to
8dbf311
Compare
This was referenced Mar 26, 2020
|
Superseded by #4861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Would close #4370 and fix #4318
Instead of finding used imports per bundle, do this directly after inserting the runtimes. By directly updating
asset.meta.symbolswith this information, we can do cross-bundle treeshaking without major changes in the scope-hoisting code itself.I've had to update the runtime mechanism to allow runtimes to insert themselves between an asset and a dependency (so act as a reexporting asset).
Potential downsides:
getUsedExportsis now single-threaded. But this is more of an API problem becauseparcel/packages/bundlers/default/src/DefaultBundler.js
Lines 279 to 281 in afd9efb
is simply running per bundle and the resulting map could be merged later.
🚨 TODO
import("./b.js").then(({ default: b }) => ...);for testing)For discussion:
DefaultBundler#propagate