-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to reexport property at build time #4364
Comments
I've identified the problem, will be fixed after the refactoring in #4411 landed. (Note to my future self: tests and an ugly fix can be found in https://github.com/parcel-bundler/parcel/tree/resolveSymbol-wrapped-reexport) |
@mischnic Are these fixes ever going to make it into 1.x? If not, could one avoid tree shaking this particular module only? |
No, also because Parcel 2's scope hoisting implementation has diverged (improved) too much at this point.
That isn't possible. |
@xtrinch fwiw (in the sort term) pinning |
Thanks @drewsynan, wish there was a better fix, but that works for me! |
🐛 bug report
Using
@sentry/browser
fails at build time withError: node_modules/@sentry/utils/esm/index.js does not export 'timestampWithMs'
.🎛 Configuration (.babelrc, package.json, cli command)
See https://github.com/garthenweb/parcel-bug-report-examples/tree/bug/sentry-does-not-export-timestampWithMs
🤔 Expected Behavior
Should create a proper build that is executable in the browser.
😯 Current Behavior
Fails with
Error: node_modules/@sentry/utils/esm/index.js does not export 'timestampWithMs'
. See https://github.com/garthenweb/parcel-bug-report-examples/tree/bug/sentry-does-not-export-timestampWithMs for more.💁 Possible Solution
timestampWithMs
is exported correctly innode_modules\@sentry\utils\esm\misc.js
which is reexported innode_modules/@sentry/utils/esm/index.js
.timestampWithMs
uses another export calledcrossPlatformPerformance
, maybe this is the source of the issue?Maybe related to #4216 but the error is different.
Works without scope hoisting.
💻 Code Sample
See https://github.com/garthenweb/parcel-bug-report-examples/tree/bug/sentry-does-not-export-timestampWithMs
🌍 Your Environment
The text was updated successfully, but these errors were encountered: