Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source maps #2

Closed
devongovett opened this issue Nov 15, 2021 · 1 comment
Closed

Source maps #2

devongovett opened this issue Nov 15, 2021 · 1 comment

Comments

@devongovett
Copy link
Member

Should use the parcel_sourcemap crate from https://github.com/parcel-bundler/source-map.

I think it would be fine to just map the rules, and not individual declarations/values. That's all browser dev tools show anyway. Should be able to get location information from the parser already, store this in the rule nodes, and generate a source map from that in the printer.
@devongovett
Copy link
Member Author

Done in 2aa85c0. Pleasantly surprised that it only adds ~0.3ms to the bootstrap benchmark when enabled. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devongovett