Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing case for showing capabilities #245

Closed
EliasC opened this issue Oct 8, 2015 · 3 comments
Closed

Missing case for showing capabilities #245

EliasC opened this issue Oct 8, 2015 · 3 comments
Assignees

Comments

@EliasC
Copy link
Contributor

EliasC commented Oct 8, 2015

Was looking for bug and came across this:

class Main
  def main() : void
    ()
encorec: src/types/Types.hs:136:3-43: Non-exhaustive patterns in function show

It seems there is a missing case for showing the empty capability. Adding -fwarn-incomplete-patterns detects this at compile time (and some other missing cases). Maybe we should add this flag as a GHC option to our build? Actually I would like us to use -Wall, but right now that gives almost 1000 lines of warnings, and I don't think anyone wants to fix those...

git blame suggests assigning @albertnetymk.

@albertnetymk
Copy link
Contributor

I can't reproduce it on master.

@EliasC
Copy link
Contributor Author

EliasC commented Oct 8, 2015

Sorry! Forgot the important detail of compiling with -AST.

@albertnetymk
Copy link
Contributor

Fixed by f232368.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants