Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internationalization: Remove percent signs surrounding localization keys during look-ups #797

Closed
lyonsil opened this issue Mar 20, 2024 · 0 comments
Closed

Internationalization: Remove percent signs surrounding localization keys during look-ups #797

lyonsil opened this issue Mar 20, 2024 · 0 comments
Milestone
2024-03 Q1 Milestone

Comments

@lyonsil
Copy link
Member

lyonsil commented Mar 20, 2024 •
edited
Loading

Right now, the menu service is removing percent signs from localization keys before calling localizationService.getLocalizedStrings because the service doesn't do that itself. Really the service ought to do that so callers don't have to repeat this code.
@lyonsil lyonsil added this to Paranext Mar 20, 2024
@lyonsil lyonsil converted this from a draft issue Mar 20, 2024
@lyonsil lyonsil added this to the 2024-03 Q1 Milestone milestone Mar 20, 2024
@lyonsil lyonsil mentioned this issue Mar 20, 2024
Merged
@lyonsil lyonsil closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in Paranext Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Paranext
Status: ✅ Done
Milestone
2024-03 Q1 Milestone
Development

No branches or pull requests
1 participant
@lyonsil