Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Settings: Implement getting project settings on C# ParatextProjectDataProvider #723

Closed
tjcouch-sil opened this issue Jan 17, 2024 · 1 comment · Fixed by #857
Closed
Assignees

Comments

@tjcouch-sil
Copy link
Member

tjcouch-sil commented Jan 17, 2024

As an extension developer, I want to be able to access Paratext-related project settings like books present on the PAPI so I can develop effectively.


Implement getSetting, setSetting, and resetSetting on the C# ParatextProjectDataProvider. See #509 for details on these functions. They must call papi.projectSettings.isValid and papi.projectSettings.getDefault appropriately.

Depends on #509, #57

@tjcouch-sil tjcouch-sil converted this from a draft issue Jan 17, 2024
@tjcouch-sil tjcouch-sil moved this to 📥 On Deck in Paranext Jan 17, 2024
@tjcouch-sil tjcouch-sil added extensions team Able to be worked on by extensions team BLOCKED Waiting on something before able to be worked labels Jan 17, 2024
@tjcouch-sil tjcouch-sil added this to the 2024-03 Q1 Milestone milestone Jan 17, 2024
@katherinejensen00 katherinejensen00 moved this from 📥 On Deck to 🎬 Product Backlog in Paranext Jan 22, 2024
@tjcouch-sil tjcouch-sil removed the extensions team Able to be worked on by extensions team label Feb 12, 2024
@katherinejensen00 katherinejensen00 removed the BLOCKED Waiting on something before able to be worked label Feb 19, 2024
@lyonsil lyonsil moved this from 🎬 Product Backlog to 🔖 ToDo in Paranext Mar 6, 2024
@lyonsil lyonsil moved this from 🔖 ToDo to 🏗 In progress in Paranext Mar 20, 2024
@lyonsil lyonsil self-assigned this Mar 20, 2024
@lyonsil lyonsil linked a pull request Apr 16, 2024 that will close this issue
@lyonsil lyonsil moved this from 🏗 In progress to 👀 In review in Paranext Apr 16, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Paranext Apr 18, 2024
@roopa0222
Copy link

Test Repo Steps:

1.On the web-view able used PAPI useProjectSettings hook to display Paratext project setting bookspresent.

const [projectParatextStandard] = useProjectSetting(
    'ParatextStandard',
    '32664DC3288A28DF2E2BB75DED887FC8F17A15FB',
    'platformScripture.booksPresent',
    '000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
  );

2.Confirmed that UI displayed the value from the setting.xml file from c-sharp/assets
Screenshot 2024-05-01 142135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants