Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Scripture Reference Selector #41

Closed
tjcouch-sil opened this issue Feb 28, 2023 · 3 comments · Fixed by #189
Closed

Create Scripture Reference Selector #41

tjcouch-sil opened this issue Feb 28, 2023 · 3 comments · Fixed by #189
Assignees

Comments

@tjcouch-sil
Copy link
Member

tjcouch-sil commented Feb 28, 2023

Create a Scripture Reference Selector component (I think there is an Open Components Ecosystem one going around... Or you can start from the one from the POC. Also see Scripture Utils. Or make your own from scratch!)

In the past, Ian made this design.
Image

Depends on #39

@tjcouch-sil tjcouch-sil converted this from a draft issue Feb 28, 2023
@tjcouch-sil tjcouch-sil moved this to 📋Product Backlog in Paranext Mar 1, 2023
@tjcouch-sil tjcouch-sil added this to the External Extension Ready milestone Mar 28, 2023
@darren8c darren8c moved this from 📋Product Backlog to 🔖 Open in Paranext Mar 29, 2023
@katherinejensen00 katherinejensen00 moved this from 🔖 Open to 📋Product Backlog in Paranext Apr 26, 2023
@rolfheij-sil rolfheij-sil moved this from 📋Product Backlog to 🔖 Open in Paranext May 5, 2023
@rolfheij-sil rolfheij-sil moved this from 🔖 Open to 🏗 In progress in Paranext May 5, 2023
@katherinejensen00
Copy link
Contributor

After talking to Darren, we decided the goal of this case is to get a basic scripture reference selector that changes the reference in Paranext. If time, there will also be research about all of the features contained in the current Paratext BCV. Nicer features will be a separate task.

@irahopkinson
Copy link
Contributor

irahopkinson commented May 10, 2023

If it helps SF has a partial port from C# to TS of the BCV utils. They are here: https://github.com/sillsdev/web-xforge/tree/master/src/RealtimeServer/scriptureforge/scripture-utils

If we want/need to use these I would copy them out into their own repo and publish them as an npm package, then let SF know about the package. I'd be happy to do that if that would help.

@katherinejensen00
Copy link
Contributor

This document holds the research done so far about what the current Libpalaso Book Chapter Verse control does.

@lyonsil lyonsil linked a pull request May 24, 2023 that will close this issue
@katherinejensen00 katherinejensen00 moved this from 🏗 In progress to ✅ Done in Paranext May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants