Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our checkbox and text field in the table component #158

Closed
tjcouch-sil opened this issue Apr 26, 2023 · 1 comment
Closed

Use our checkbox and text field in the table component #158

tjcouch-sil opened this issue Apr 26, 2023 · 1 comment
Assignees

Comments

@tjcouch-sil
Copy link
Member

tjcouch-sil commented Apr 26, 2023

It would be good to use our checkbox component and our text field component for the select column and the default text editor in the table component to be consistent with our styling.

@tjcouch-sil tjcouch-sil converted this from a draft issue Apr 26, 2023
@tjcouch-sil tjcouch-sil moved this to 📋Product Backlog in Paranext Apr 26, 2023
@rolfheij-sil rolfheij-sil self-assigned this May 25, 2023
@rolfheij-sil rolfheij-sil moved this from 📋Product Backlog to 🏗 In progress in Paranext May 25, 2023
@irahopkinson
Copy link
Contributor

irahopkinson commented Jun 1, 2023

Before #179 (PR #207), papi-components didn't include the table or the checkbox. As in src/renderer/components/papi-components/index.ts doesn't include table or checkbox. PR #207 moves papi-components to an external module and outside of papi itself. So lib/papi-components/src/index.ts has been updated to inlude the checkbox but has left including the table for this issue. You can also add an example table to extensions/lib/hello-world/hello-world.web-view.tsx to check it's working along with the other examples.

@rolfheij-sil rolfheij-sil moved this from 🏗 In progress to 👀 In review in Paranext Jun 16, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Paranext Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants