Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Revisit threading and web socket handling #137

Closed
lyonsil opened this issue Apr 6, 2023 · 0 comments · Fixed by #140
Closed

C#: Revisit threading and web socket handling #137

lyonsil opened this issue Apr 6, 2023 · 0 comments · Fixed by #140
Assignees

Comments

@lyonsil
Copy link
Member

lyonsil commented Apr 6, 2023

In light of this node in the .NET web socket source code, I need to revisit some threading choices made.

Adding a thread to handle receiving messages was still a good choice. The problem is that more than 1 thread at a time may be able to send messages at the same time which this socket implementation doesn't support.

@lyonsil lyonsil added this to Paranext Apr 6, 2023
@lyonsil lyonsil converted this from a draft issue Apr 6, 2023
@lyonsil lyonsil self-assigned this Apr 10, 2023
@lyonsil lyonsil moved this from 📋Product Backlog to 🔖 Open in Paranext Apr 10, 2023
@lyonsil lyonsil moved this from 🔖 Open to 🏗 In progress in Paranext Apr 10, 2023
@lyonsil lyonsil moved this from 🏗 In progress to 👀 In review in Paranext Apr 10, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Paranext Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant