Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UnsubAndPromise pattern #126

Closed
tjcouch-sil opened this issue Apr 3, 2023 · 0 comments · Fixed by #202
Closed

Remove UnsubAndPromise pattern #126

tjcouch-sil opened this issue Apr 3, 2023 · 0 comments · Fixed by #202
Assignees
@lyonsil

Comments

@tjcouch-sil
Copy link
Member

The UnsubAndPromise pattern is complex code that no one wants to use. It prevents using async/await, requires weird utility functions to make safe, and makes using the api harder. Remove it and replace with Promise<UnsubscriberAsync>
@tjcouch-sil tjcouch-sil converted this from a draft issue Apr 3, 2023
@tjcouch-sil tjcouch-sil moved this to 📋Product Backlog in Paranext Apr 3, 2023
@tjcouch-sil tjcouch-sil added this to the External Extension Ready milestone Apr 3, 2023
@lyonsil lyonsil moved this from 📋Product Backlog to 🔖 Open in Paranext May 19, 2023
@lyonsil lyonsil self-assigned this May 19, 2023
@lyonsil lyonsil moved this from 🔖 Open to 🏗 In progress in Paranext May 19, 2023
@lyonsil lyonsil linked a pull request May 19, 2023 that will close this issue
Replace {unsubscriber, promise} with Promise<UnsubscriberAsync> #202
Merged
@lyonsil lyonsil moved this from 🏗 In progress to 👀 In review in Paranext May 19, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Paranext May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyonsil lyonsil

Labels
None yet
Projects
Paranext
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace {unsubscriber, promise} with Promise<UnsubscriberAsync> paranext/paranext-core
2 participants
@tjcouch-sil @lyonsil