Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default text input style to match shadcn #1160

Closed
Sebastian-ubs opened this issue Sep 26, 2024 · 3 comments · Fixed by #1230
Closed

Update default text input style to match shadcn #1160

Sebastian-ubs opened this issue Sep 26, 2024 · 3 comments · Fixed by #1230
Assignees
Labels
bug Something isn't working

Comments

@Sebastian-ubs
Copy link
Contributor

Describe the bug
All text input fields are invisible in their default style

grafik
see https://discord.com/channels/1064938364597436416/1288209312342347806/1288515124629340221

To Reproduce
In Paratext 10

  1. Click the hamburger to see the main menu
  2. Open "settings"
    when in Paratext 10
  3. Navigate to "Mercurial config" and click inside the center of the white space to the right
    or in Platform
  4. Navigate to "Platform Settings" and click on { bookNum": ...

grafik

Expected behavior
Not sure why our input looks different than the shadcn one, but:

shadcn website Screenshot 2024-09-26 131802
with paratext theme this should look like grafik
@Sebastian-ubs Sebastian-ubs added the bug Something isn't working label Sep 26, 2024
@tjcouch-sil
Copy link
Member

Do you know if this problem exists other than in the settings dialog? Just interested to know the scope of the issue :) if you don't know offhand, that's fine.

@Sebastian-ubs
Copy link
Contributor Author

I assume it is for all text inputs, as in the preview app they also show "invisible". Effort however should be low just fixing the base component style and check if that does not break any consuming components (if that's the case they should be adjusted).

@tjcouch-sil tjcouch-sil moved this to 🏗 In progress in Paranext Oct 18, 2024
@tjcouch-sil tjcouch-sil self-assigned this Oct 18, 2024
@tjcouch-sil tjcouch-sil moved this from 🏗 In progress to 👀 In review in Paranext Oct 18, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Paranext Oct 18, 2024
@roopa0222
Copy link

I verified the PBR Input (Shacn) with the latest code fix. The input reflects the style applied in the fix.

Screenshot 2024-10-21 121416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants