Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shortfalls using treasury #419

Closed
wants to merge 14 commits into from
Closed

fix: shortfalls using treasury #419

wants to merge 14 commits into from

Conversation

GopherJ
Copy link
Contributor

@GopherJ GopherJ commented Sep 27, 2023

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@GopherJ GopherJ requested a review from a team as a code owner September 27, 2023 09:04
@GopherJ
chore: improve strategy
d236d7c 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: add test script
906da06 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: parameters deploy
f89e4dd 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: typo
bbd6f43 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: add missing approval
867be2f 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: unable to withdraw on behalf of others
919b447 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: typo
d939c1c 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: typo
f117f5a 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: stETH approval
1a5a503 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: typo
743d73c 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: cape amount
4da0e3b 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: burn also debt
6e3aa82 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: typo
d679f46 
Signed-off-by: GopherJ <[email protected]>
@GopherJ GopherJ closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GopherJ