Fix MSRV-related issues #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superhepper
reviewed
Sep 13, 2023
wiktor-k
reviewed
Sep 14, 2023
Fixing the MSRV in our CI involves making sure that the crate can build under that version of the Rust compiler, given some choice of dependencies that are also compatible with the MSRV. A major issue is that many crates bump the MSRV in patch or minor releases that then get picked up automatically if no lock file is present. This commit adds a lock file for our current MSRV, and pins the MSRV for clippy as well. Signed-off-by: Ionut Mihalcea <[email protected]>
ionut-arm
force-pushed
the
msrv-fixes
branch
from
5702116
to
35c73a5
Compare
Superhepper
approved these changes
Sep 15, 2023
wiktor-k
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the MSRV in our CI involves making sure that the crate can build under that version of the Rust compiler, given some choice of dependencies that are also compatible with the MSRV. A major issue is that many crates bump the MSRV in patch or minor releases that then get picked up automatically if no lock file is present.
This commit adds a lock file for our current MSRV, and pins the MSRV for clippy as well.