-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unecessary modules in mod.rs files #313
Comments
Do you reckon we should just keep the type exports and not make the modules public, to keep the import tree flat? |
Yeah, just make everything available under structures like it already is. There is no need to provide alternative module 'paths' to the same thing for us. We do not have like backward compatibility to take into consideration here. I think I was the one introduced this a long time ago because the standard library did this. But for us it makes no sense. |
Hmm, just noticed something odd. For some reason there's a separate module for non-volatile-related structures. Any reason for that? They seem very similar to the stuff we have in Would it make sense for me to move them around to Another question that doesn't really belong in this thread, but I don't want to open a new issue just for it - we have |
I think the reason for the nv module is because that is how it is laid out in the specification. How the code should be laid out in our source tree is something I have been pondering about for a long time. The reason I have not been able to come up with a good answer is because we want the modules to intuitive to people who uses the crate and reads the specification. So to some degree we have laid things out as the specification has. But the specification in it self is not consistent!! Sometimes it places things under a specific type topic and sometimes it places the types under subsection of structures even though they are perhaps interface types (rant is over). So would it make sense to move nv to structures? If we look at the specification then the answer is no, but I wouldn't say anything if it ended up there any way. |
Extra modules such as:
Does not serve any real purpose and should be removed.
The text was updated successfully, but these errors were encountered: