Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to inclusive bindgen naming #60

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

vkkoskie
Copy link
Contributor

@vkkoskie vkkoskie commented Nov 4, 2021

The bindgen crate has deprecated several methods in favor of more inclusive alternative spellings. Introduces no functional change.

@mike-boquard
Copy link
Collaborator

Just to verify it does not change the output of the generated .rs files, correct?

@vkkoskie
Copy link
Contributor Author

vkkoskie commented Nov 4, 2021

Correct. bindgen refers to these as aliases to the items they deprecated. You're already using the most recent version of bindgen, so it doesn't even require a change to Cargo.toml.

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I noticed these some time ago but forgot to update/raise an issue

@mike-boquard mike-boquard merged commit 8bd4ba6 into parallaxsecond:main Nov 5, 2021
@vkkoskie vkkoskie deleted the bindgen-deprecations branch November 6, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants