-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update provider to use new version fo TransKeyCtx #515
Conversation
aa0143e
to
4d54d8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall approach looks good to me.
Cargo.toml
Outdated
@@ -29,7 +29,7 @@ log = { version = "0.4.14", features = ["serde"] } | |||
cryptoki = { version = "0.2.0", optional = true, features = ["psa-crypto-conversions"] } | |||
picky-asn1-der = { version = "<=0.2.4", optional = true } | |||
picky-asn1 = { version = ">=0.3.1, <=0.3.1", optional = true } | |||
tss-esapi = { version = "6.1.0", optional = true } | |||
tss-esapi = { git = "https://github.com/ionut-arm/rust-tss-esapi", branch = "trans-key-ctx-2", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that this will become a version spec once the TSS crate changes are upstreamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! Just a few comments.
This commit updates the TPM provider to use the updated version of the TransientKeyContext which handles key material in the form of public and private fields (instead of an encrypted context). A migration mechanism is also added, to aid in the recovery of keys stored as contexts. It also adds a replace_key_info method to the KIM client, which allows the above-mentioned migration to be done in a data-race safe way. Signed-off-by: Ionut Mihalcea <[email protected]>
4e59725
to
b3bb5ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This commit updates the TPM provider to use the updated version of the
TransientKeyContext which handles key material in the form of public and
private fields (instead of an encrypted context).
Signed-off-by: Ionut Mihalcea [email protected]