Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provider to use new version fo TransKeyCtx #515

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

ionut-arm
Copy link
Member

This commit updates the TPM provider to use the updated version of the
TransientKeyContext which handles key material in the form of public and
private fields (instead of an encrypted context).

Signed-off-by: Ionut Mihalcea [email protected]

@ionut-arm ionut-arm force-pushed the trans-key-ctx branch 2 times, most recently from aa0143e to 4d54d8c Compare September 13, 2021 10:48
@ionut-arm ionut-arm added bug Something isn't working enhancement New feature or request labels Sep 13, 2021
@ionut-arm ionut-arm self-assigned this Sep 13, 2021
@ionut-arm ionut-arm added this to the Parsec Release 0.8.0 milestone Sep 13, 2021
Copy link
Collaborator

@paulhowardarm paulhowardarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall approach looks good to me.

Cargo.toml Outdated
@@ -29,7 +29,7 @@ log = { version = "0.4.14", features = ["serde"] }
cryptoki = { version = "0.2.0", optional = true, features = ["psa-crypto-conversions"] }
picky-asn1-der = { version = "<=0.2.4", optional = true }
picky-asn1 = { version = ">=0.3.1, <=0.3.1", optional = true }
tss-esapi = { version = "6.1.0", optional = true }
tss-esapi = { git = "https://github.com/ionut-arm/rust-tss-esapi", branch = "trans-key-ctx-2", optional = true }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that this will become a version spec once the TSS crate changes are upstreamed.

src/providers/tpm/key_management.rs Outdated Show resolved Hide resolved
Copy link
Member

@MattDavis00 MattDavis00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! Just a few comments.

e2e_tests/tests/per_provider/tpm_reset.rs Show resolved Hide resolved
src/providers/tpm/utils.rs Show resolved Hide resolved
src/providers/tpm/utils.rs Outdated Show resolved Hide resolved
src/providers/tpm/utils.rs Outdated Show resolved Hide resolved
@ionut-arm ionut-arm marked this pull request as ready for review September 17, 2021 08:58
@ionut-arm ionut-arm requested a review from a team as a code owner September 17, 2021 08:58
This commit updates the TPM provider to use the updated version of the
TransientKeyContext which handles key material in the form of public and
private fields (instead of an encrypted context). A migration mechanism
is also added, to aid in the recovery of keys stored as contexts.
It also adds a replace_key_info method to the KIM client, which allows
the above-mentioned migration to be done in a data-race safe way.

Signed-off-by: Ionut Mihalcea <[email protected]>
Copy link
Member

@MattDavis00 MattDavis00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ionut-arm ionut-arm merged commit 06de5c9 into parallaxsecond:main Sep 17, 2021
@ionut-arm ionut-arm deleted the trans-key-ctx branch September 17, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants