Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TPM provider cross-compilation #403

Merged
merged 2 commits into from
May 7, 2021

Conversation

ionut-arm
Copy link
Member

@ionut-arm ionut-arm commented Apr 23, 2021

This commit adds cross-compilation for the TPM provider and moves all
the cross-compilation into a dedicated Docker container.

The image needed for cross-compilation hasn't been published yet, waiting for a brief review first.

Fixes #382

@ionut-arm ionut-arm added enhancement New feature or request code health Issues concerning overall code quality, safety and best practice labels Apr 23, 2021
@ionut-arm ionut-arm requested a review from hug-dev April 23, 2021 13:40
@ionut-arm ionut-arm self-assigned this Apr 23, 2021
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thank you! Small nits but I am ok as it is!

@ionut-arm
Copy link
Member Author

Note: cross-compilation build seems to run ok, but I'm still waiting for parallaxsecond/rust-tss-esapi#226 to make it succeed.

@ionut-arm ionut-arm force-pushed the cross-compile-tpm branch 3 times, most recently from f9e7b81 to 450a60c Compare May 6, 2021 10:20
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

src/providers/mbed_crypto/asym_encryption.rs Show resolved Hide resolved
This commit adds cross-compilation for the TPM provider and moves all
the cross-compilation into a dedicated Docker container.

Signed-off-by: Ionut Mihalcea <[email protected]>
Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm ionut-arm merged commit a238ad7 into parallaxsecond:main May 7, 2021
@ionut-arm ionut-arm deleted the cross-compile-tpm branch May 7, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Issues concerning overall code quality, safety and best practice enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cross-compilation tests for the TPM provider
2 participants