Fix clippy errors #206
Merged
Fix clippy errors #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes clippy warnings in the new version of the Rust compiler (1.45.0). Most of the errors refer to misuse of `or_else`, where an error is mapped exclusively to another error. `map_err` should be used instead. The other warnings are around useless type conversions between identical types. Signed-off-by: Ionut Mihalcea <[email protected]>
hug-dev
reviewed
Jul 17, 2020
| .unwrap(); | ||
| let _res = client | ||
| .asymmetric_decrypt_message_with_rsapkcs1v15(key_name_2.clone(), ciphertext) |
There was a problem hiding this comment.
I'm sure that clippy warned us for issues similar than this one before!
hug-dev
approved these changes
Jul 17, 2020
| @@ -153,7 +153,7 @@ impl Pkcs11Provider { | |||
| let key_name = op.key_name; | |||
| let key_attributes = op.attributes; | |||
| // This should never panic on 32 bits or more machines. | |||
| let key_size = std::convert::TryFrom::try_from(op.attributes.bits).unwrap(); | |||
| let key_size = op.attributes.bits; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes clippy warnings in the new version of the Rust compiler
(1.45.0). Most of the errors refer to misuse of
or_else, where anerror is mapped exclusively to another error.
map_errshould be usedinstead. The other warnings are around useless type conversions between
identical types.
Signed-off-by: Ionut Mihalcea [email protected]