Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability: systemd communication #396

Closed
hug-dev opened this issue Apr 14, 2021 · 2 comments
Closed

Stability: systemd communication #396

hug-dev opened this issue Apr 14, 2021 · 2 comments
Assignees
Labels
stability Issues related to the stability of the service

Comments

@hug-dev
Copy link
Member

hug-dev commented Apr 14, 2021

Definition: systemd should receive the same status information from Parsec in future stable versions.
Enforcement: Status notifications must not be removed.

Enforcement Check

Parsec notifies systemd that it is ready/reloading/stopping using sd_notify. This behaviour should remain the same for future stable Parsec versions.

This can only be checked via testing/code review. We can also add warnings in the code, move the relevent files in different modules.

Testing

The systemd communication should be tested for different versions of Parsec.

@hug-dev hug-dev added the stability Issues related to the stability of the service label Apr 14, 2021
@hug-dev
Copy link
Member Author

hug-dev commented Apr 21, 2021

All existing systemd communication should be tested. New tests should be added if more communication channels with systemd are used.
Similar code separation feature as in #392

@hug-dev hug-dev added this to the Parsec Release 0.8.0 milestone May 5, 2021
@hug-dev hug-dev self-assigned this Jun 18, 2021
@hug-dev
Copy link
Member Author

hug-dev commented Jun 18, 2021

The different notification sent to systemd are: "ready", "reloading" and "stopping".

Those status can be checked using systemctl --user start parsec and seen when the service is started (ready), when it is reloading (after a systemctl --user kill -s HUP parsec) and when it is stopping (after a systemctl --user stop parsec).

I have been reading through this, this and this that since our systemd unit file is not Type=notify, these status are only informational for the user when doing systemctl --user start parsec.

It is not possible to test the systemd integration with Docker. It might be enough to do systemd integration tests during the code freeze period, ahead of releases.

@hug-dev hug-dev closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability Issues related to the stability of the service
Projects
None yet
Development

No branches or pull requests

1 participant