Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct lint issues found after the toolchain upgrade to version 1.49.0 #305

Closed
RobertDrazkowskiGL opened this issue Jan 5, 2021 · 1 comment · Fixed by #306
Closed

Comments

@RobertDrazkowskiGL
Copy link
Contributor

The newly released (01.01.2021) rust toolchain version 1.49.0 found a following lint problem:

error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
  --> src/providers/pkcs11/key_metadata.rs:16:5
   |
16 | /     pub(super) fn get_ordered_locks<'a>(
17 | |         &'a self,
18 | |     ) -> (
19 | |         &'a RwLock<dyn ManageKeyInfo + Send + Sync>,
20 | |         &'a RwLock<LocalIdStore>,
21 | |     ) {
   | |_____^
   |
   = note: `-D clippy::needless-lifetimes` implied by `-D clippy::all`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

It needs to be fixed to unblock further development, including merging PR#303 (a new CryptoAuthentication Library based provider).

@ionut-arm
Copy link
Member

This will need to be solved for all the other parallaxsecond crates as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants