-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Docker images into own repo #124
Comments
Should we also produce images with parsec deployed? |
Agree with that! It would also remove the duplication of the TPM image we use in the TSS crate and in the service. Do we care about publishing "testing" images on Dockerhub? Is it meant for all kind of images or only "production" quality ones? |
Again referring to the TPM2 example, their images are for CI purposes. So that should be fine.
I think that would be a good idea when we figure out exactly how we want to deploy it. Would that mean a Docker image with a deployed service inside, but for which the customer has to provide the config file and libraries/handles for connecting to the hardware backends? And the container would outsource its socket(s) somehow |
I don't think parsec should be a service in the image. It should be run as a command instead.
|
we might provide separate images for each provider for example. Do we expect cases where more than one provider would be required from the service (except CI/testing)? |
Yes, sorry, that's what I meant! I think we can provide one image that has all the dependencies and the admin just links in and configures the desired one(s) |
I'm not sure. What's the point to include libraries which won't be used? I think we should try to create as small images as possible. i.e. separate images for different backends. |
I'm working to build a container image that can be used for all our CI tests (well, for the service, at least). This will be a fairly large image as it requires dependencies for all different providers, but will be published in Github's container image registry and simply downloaded (instead of built) for every CI run. This should save us a lot of build time. I'm unsure about whether I should simply publish the individual provider images as well (at least for PKCS11 and Mbed Crypto). The images would be much smaller, so quicker to download. But at the same time, there would be more than one image to maintain and there would be duplication between those ones and the |
One year later 😄 |
Done with #357 |
For both CI and local testing we make use of specific Docker images that offer all the dependencies/functionality that we need (e.g. SoftHSM library or TPM2 simulator).
While these are mostly used for testing at the moment, they could provide a good environment for users to try out their own integrations in the future.
The image definitions could be pulled into a separate repo and maintained there (the way the TPM2 guys do) and upstreaming said images to Dockerhub. This has the benefit of allowing direct usage of the images anywhere and greatly reduced CI build times.
The text was updated successfully, but these errors were encountered: