Add a JWT SVID authentication type #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this is not currently documented in our book, it is useful to start building it on a PoC level. Signed-off-by: Hugues de Valon <[email protected]>
paulhowardarm
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Looks good. The original Jwt entry (2) in this list might end up becoming redundant, because JWT is really just a data format and not truly a method of authentication. But that's okay, it does no harm really. Makes perfect sense for SPIFFE to be a separate/new entry.
ionut-arm
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this is not currently documented in our book, it is useful to
start building it on a PoC level.
Signed-off-by: Hugues de Valon [email protected]