-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ProviderID #36
Comments
Should we also with this issue, refactor the |
I think this will be painful to change because a lot of things depend on a clear mapping from |
Should think about that in parallaxsecond/parsec-book#83 |
Hmm, that's true, I think the stability issue here is related to the interface of the client - how do users specify they want "That particular provider!". At the moment the list is static, in the future it could change. I've written a short comment on the issue above, will close this and raise a more clear issue once we get to it. |
I have a feeling that the
ProviderID
isn't really named appropriately anymore.Provider
would probably be a better name, as we use the enum to identify the type of provider we're refering to throughout the stack, not just for managing their IDsThe text was updated successfully, but these errors were encountered: