Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ProviderID #36

Closed
ionut-arm opened this issue Mar 23, 2020 · 4 comments
Closed

Rename ProviderID #36

ionut-arm opened this issue Mar 23, 2020 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@ionut-arm
Copy link
Member

I have a feeling that the ProviderID isn't really named appropriately anymore. Provider would probably be a better name, as we use the enum to identify the type of provider we're refering to throughout the stack, not just for managing their IDs

@hug-dev
Copy link
Member

hug-dev commented Aug 7, 2020

Should we also with this issue, refactor the ProviderID type completely? I think we agreed that in the future, if we have multiple providers of the same type, this won't work anymore. Maybe ProviderID should just be a new type composed of a value + a type?

@hug-dev hug-dev added bug Something isn't working enhancement New feature or request labels Aug 7, 2020
@hug-dev hug-dev added this to the Parsec production ready milestone Aug 7, 2020
@ionut-arm
Copy link
Member Author

I think this will be painful to change because a lot of things depend on a clear mapping from ProviderID to provider type, but that's more of an incentive to do that sooner before we hardcode even more stuff to that assumption

@hug-dev hug-dev removed this from the Parsec production ready milestone Sep 2, 2020
@hug-dev
Copy link
Member

hug-dev commented Feb 3, 2021

Should think about that in parallaxsecond/parsec-book#83

@ionut-arm
Copy link
Member Author

Should think about that in parallaxsecond/parsec-book#83

Hmm, that's true, I think the stability issue here is related to the interface of the client - how do users specify they want "That particular provider!". At the moment the list is static, in the future it could change. I've written a short comment on the issue above, will close this and raise a more clear issue once we get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants