-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump alloy 4e22b9e #7895
chore: bump alloy 4e22b9e #7895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, fewer alloy changes is good
the most significant change was to: Option<TxKind>
on the tx request.
this nuance has no impact on the server side and we can always use unwrap_or_default
20f9eaf
to
37f4d28
Compare
yep, there were also other minor changes in alloy's serde. wrt to the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sound to me defaulting to create, my nits can be looked at in a follow up
for clarity None
means that the user did not specify what they wanted to do with the transaction request and the node should instead infer, the only thing we can probably infer is that it should be a create
37f4d28
to
9b3ebcf
Compare
Towards #7702