Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump alloy 4e22b9e #7895

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Apr 25, 2024

Towards #7702

@onbjerg onbjerg added the A-dependencies Pull requests or issues that are about dependencies label Apr 25, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, fewer alloy changes is good

the most significant change was to: Option<TxKind> on the tx request.

this nuance has no impact on the server side and we can always use unwrap_or_default

@onbjerg
Copy link
Member

onbjerg commented Apr 25, 2024

@fgimenez #7885 is being merged which will have a small impact on this PR

@fgimenez
Copy link
Member Author

@fgimenez #7885 is being merged which will have a small impact on this PR

awesome thanks for the heads up!

@fgimenez fgimenez force-pushed the fgimenez/bump-alloy4e22b9e branch from 20f9eaf to 37f4d28 Compare April 26, 2024 07:39
@fgimenez
Copy link
Member Author

the most significant change was to: Option<TxKind> on the tx request.

this nuance has no impact on the server side and we can always use unwrap_or_default

yep, there were also other minor changes in alloy's serde.

wrt to the new to type in TransactionRequest, we previously had Option<Address> and I assume that None here was interpreted as a create transaction. Now we have Option<TxKind>, we have Some(TxKind::Call(to)) and Some(TxKind::Create), how should we interpret None now? In the changes in this PR None means create too (same as Some(TxCall::Create)), let me know if that's correct.

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sound to me defaulting to create, my nits can be looked at in a follow up

for clarity None means that the user did not specify what they wanted to do with the transaction request and the node should instead infer, the only thing we can probably infer is that it should be a create

crates/rpc/rpc-types-compat/src/transaction/mod.rs Outdated Show resolved Hide resolved
crates/rpc/rpc/src/eth/api/transactions.rs Outdated Show resolved Hide resolved
@fgimenez fgimenez force-pushed the fgimenez/bump-alloy4e22b9e branch from 37f4d28 to 9b3ebcf Compare April 26, 2024 14:50
@fgimenez fgimenez enabled auto-merge April 26, 2024 15:02
@fgimenez fgimenez added this pull request to the merge queue Apr 26, 2024
Merged via the queue into paradigmxyz:main with commit 953ba04 Apr 26, 2024
29 checks passed
@fgimenez fgimenez deleted the fgimenez/bump-alloy4e22b9e branch April 26, 2024 15:16
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants