Improve eth_getLogs performance for latest block

[leontiad]

Solves #5680

[allnil]

Hey!
small nit: I think that the idiomatic way in Rust and across the repo is not to add ";" in return statements
maybe you have some auto-fmt tooling that put ";" after returns
I got such problems a few times in my rust setup
Try to use "cargo +nightly fmt" , it helps!
ps
cargo clippy --bin "reth" --workspace --features "ethereum" --lib --tests --benches --examples
and this one to check lints

[gakonst]

@leontiad thanks for taking the time here! what's missing for us to take a look?

[mattsse]

ah my bad, this one slipped through

going over this asap

[leontiad]

@leontiad thanks for taking the time here! what's missing for us to take a look?

I am having an issue with http::test_call_filter_functions_http test

[leontiad]

Overall thank you for the support ! As a generic comment as a first contributor I was confused on what local tests/fmt/clippy I need to run before pushing and open the PR. Unless I miss it and is already there a one command line unifying all clippy/formatter/tests would really help.

[Rjected]

Overall thank you for the support ! As a generic comment as a first contributor I was confused on what local tests/fmt/clippy I need to run before pushing and open the PR. Unless I miss it and is already there a one command line unifying all clippy/formatter/tests would really help.

you can actually run make lint to run the clippy / formatter. For tests I usually just test things close to what I'm editing, but if you want something universal (although it may take longer), you can use make test-unit or cargo nextest run --workspace

[leontiad]

Overall thank you for the support ! As a generic comment as a first contributor I was confused on what local tests/fmt/clippy I need to run before pushing and open the PR. Unless I miss it and is already there a one command line unifying all clippy/formatter/tests would really help.

you can actually run make lint to run the clippy / formatter. For tests I usually just test things close to what I'm editing, but if you want something universal (although it may take longer), you can use make test-unit or cargo nextest run --workspace

thanks, I need some help with a failing test. Can someone have a look @mattsse

[mattsse]

very sorry for the delayed review here -.-

this is going in the right direction and is pretty close.

I only have one suggestion to get rid of the block_hash and latest lookup, by reusing the previously fetched ChainInfo object

[mattsse]

nice!

tysm!

[gakonst]

🚀 🚀 🚀