Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fcu v3 skeleton #3940

Merged
merged 2 commits into from
Jul 27, 2023
Merged

feat: add fcu v3 skeleton #3940

merged 2 commits into from
Jul 27, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 27, 2023

@mattsse mattsse requested a review from Rjected as a code owner July 27, 2023 05:38
@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #3940 (557e685) into main (b5a44ae) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/consensus/beacon/src/engine/message.rs 41.17% <ø> (ø)
crates/rpc/rpc-api/src/engine.rs 50.00% <ø> (ø)
crates/rpc/rpc-engine-api/src/engine_api.rs 83.72% <0.00%> (-3.95%) ⬇️
crates/rpc/rpc-engine-api/src/message.rs 0.00% <ø> (ø)
crates/rpc/rpc-types/src/eth/engine/payload.rs 88.91% <ø> (ø)

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.55% <0.00%> (+<0.01%) ⬆️
unit-tests 64.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.18% <ø> (ø)
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.29% <ø> (ø)
trie 94.70% <ø> (ø)
txpool 46.56% <ø> (+0.56%) ⬆️
networking 77.65% <ø> (-0.02%) ⬇️
rpc 58.75% <0.00%> (-0.11%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.94% <ø> (ø)

@mattsse mattsse requested a review from rkrasiuk as a code owner July 27, 2023 06:58
rkrasiuk
rkrasiuk reviewed Jul 27, 2023
View reviewed changes
crates/rpc/rpc-api/src/engine.rs
///
/// Note: This method will be deprecated after the cancun hardfork:
///
/// > Consensus and execution layer clients MAY remove support of this method after Cancun. If
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we create a separate issue for cleaning up capabilities, so we don't forget?

rkrasiuk
rkrasiuk approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rkrasiuk rkrasiuk added the E-cancun Related to the Cancun network upgrade label Jul 27, 2023
@mattsse mattsse added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit f98b152 Jul 27, 2023
@mattsse mattsse deleted the matt/add-fcu-v3 branch July 27, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation E-cancun Related to the Cancun network upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk