chore: change BlockAndProofV1 to use alloy_eips instead
#10969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattsse this is what is intended right? alloy-rs/alloy#1300 -> moves type to alloy -> remove type here -> change to use |
mattsse
approved these changes
Sep 17, 2024
mattsse
added
the
S-blocked
|
hadn't update cargo.toml but should be updated to add alloy_eips wherever needed. lmk if you need anything when you bump alloy dep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10788 when combined with alloy-rs/alloy#1300
Currently needs an alloy dep bump to work